test(canon): refresh npmx snapshot in the canonical fixture env#3207
Merged
Conversation
The npmx.dev check snapshot was the one real-project baseline that could not be refreshed alongside #3203/#3205 and failed App E2E at the v0.299.1 release commit, blocking the preflight. The canonical environment resolves modules through the ancestor tests/node_modules without installing inside the pinned checkout — an in-fixture install shadows that resolution and erases the baseline's intentional unresolved-module diagnostics. Regenerated in that canonical state: file count and the 24 intentional TS2307s are unchanged, positions move onto attribute names, duplicate diagnostics that collapsed onto shared positions merge, and every actual line visible in the truncated App E2E assertion diff matches this regeneration exactly (8/8).
ubugeeei
enabled auto-merge (squash)
July 22, 2026 07:01
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
github-actions
Bot
changed the title
vize
@vizejs/fresco
@vizejs/musea-mcp-server
oxlint-plugin-vize
@vizejs/rspack-plugin
@vizejs/unplugin
@vizejs/vite-plugin
@vizejs/vite-plugin-musea
@vizejs/musea-nuxt
@vizejs/nuxt
@vizeui/core
commit: |
Contributor
PR BenchmarkBase:
Raw run timesCompile SFC
Lint
Format
Type check (1T)
Type check (max)
|
Contributor
Detailed Test ReportCommit: Area Summary
Test InventoryTotal tracked cases: 9478 across 1465 files.
Files
Comment truncated at 64000 characters. Open the workflow run for the full job log. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unblocks the release preflight: the npmx.dev check snapshot was the one real-project baseline that could not be refreshed alongside #3203/#3205, and it failed App E2E at the v0.299.1 release commit — the preflight then failed closed with nothing published from CI.
Canonical environment discovery
The fixture's module resolution is ancestor-based by design: the pinned checkout has no own install, so imports resolve through
tests/node_modules, leaving 24 intentionalTS2307unresolved-module diagnostics as part of the baseline. Running an install inside the pinned checkout shadows that resolution and silently erases them — which is why a naive local refresh was wrong before and is documented in the commit for the next person.Verification
After this merges (with Fuzz green on main), the release reruns as v0.299.2 — the v0.299.1 preflight is pinned to its tag SHA and correctly cannot be revived.
Part of #2971
Need help on this PR? Tag
/codesmithwith what you need. Autofix is enabled.