feat: cycle edge tiles through equal widths - #463
Draft
2001Y wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Edge Cycledynamic keybinding behavior.npm testCI step.Behavior
With Preferences → General → Dynamic Keybinding Behavior → Edge Cycle enabled:
If the active window is not already at the requested edge in a recognized full-height state, the first press selects the corresponding half-width tile. Pressing the opposite direction starts the opposite edge at half width. The current intended
tiledRectis used for state detection so configured Tiling Assistant gaps do not break the cycle.No default GNOME shortcut is changed. Users who want vertical-only behavior for
Super+Upcan assign the existingtile-maximize-verticallyaction manually after clearing the normaltile-maximizebinding.Implementation
DynamicKeybindings.EDGE_CYCLEas a new settings mode.edgeCycle.jshelper for:RectandTilingWindowManager.tile()for Wayland-native window movement, gap handling, restore/unmaximize behavior, and tile state management.0(Disabled).Validation
npm test— 6 tests passed.git diff --check— passed.scripts/build.sh— passed; extension package generated.The built extension was installed into the user extension directory. The current Wayland GNOME Shell session still reports the pre-existing system copy as active; a GNOME Shell/session restart is required before exercising the new keybindings interactively.
Review focus
Edge Cycleshould remain part of the existing dynamic-keybinding mode selector or become a separate setting.