PAM: Add support for more native pam features and initial support for gdm #31
3v1n0Annotations
11 errors and 10 warnings
|
Code sanity:
internal/services/pam/pam.go#L33
exported: comment on exported method Service.AvailableBrokers should be of the form "AvailableBrokers ..." (revive)
|
|
Code sanity:
internal/services/pam/pam.go#L56
exported: comment on exported method Service.SelectBroker should be of the form "SelectBroker ..." (revive)
|
|
Code sanity:
internal/services/pam/pam.go#L173
exported: exported method Service.SetDefaultBrokerForUser should have comment or be unexported (revive)
|
|
Code sanity:
internal/log/log.go#L56
exported: comment on exported function Errorf should be of the form "Errorf ..." (revive)
|
|
Code sanity:
internal/brokers/examplebroker.go#L463
Comment should end in a period (godot)
|
|
Code sanity:
internal/brokers/examplebroker.go#L483
Comment should end in a period (godot)
|
|
Code sanity:
internal/brokers/localbroker.go#L11
Comment should end in a period (godot)
|
|
Code sanity:
internal/brokers/broker.go#L1
package-comments: should have a package comment (revive)
|
|
Code sanity:
internal/brokers/manager.go#L15
exported: exported type Manager should have comment or be unexported (revive)
|
|
Code sanity:
internal/brokers/manager.go#L40
exported: exported function NewManager should have comment or be unexported (revive)
|
|
Tests
Process completed with exit code 1.
|
|
Code sanity:
pam/pam.go#L34
var-declaration: should omit type error from declaration of var errGoBack; it will be inferred from the right-hand side (revive)
|
|
Code sanity:
pam/pam.go#L487
var-naming: var sessionId should be sessionID (revive)
|
|
Code sanity:
pam/utils_c.go#L20
exported: exported type PamPrompt should have comment or be unexported (revive)
|
|
Code sanity:
pam/utils_c.go#L23
exported: exported const PamPromptEchoOff should have comment (or a comment on this block) or be unexported (revive)
|
|
Code sanity:
pam/pam.go#L168
redefines-builtin-id: redefinition of the built-in function close (revive)
|
|
Code sanity:
pam/pam.go#L846
redefines-builtin-id: redefinition of the built-in function close (revive)
|
|
Code sanity:
pam/pam.go#L45
exported: exported type ClientType should have comment or be unexported (revive)
|
|
Code sanity:
pam/pam.go#L48
exported: exported const ClientTypeNone should have comment (or a comment on this block) or be unexported (revive)
|
|
Code sanity:
pam/pam.go#L54
exported: exported type PAMClient should have comment or be unexported (revive)
|
|
Code sanity:
pam/pam.go#L74
exported: exported type PAMClientBase should have comment or be unexported (revive)
|