Finish linting fixes.

pam/authmodeselection.go

@@ -90,7 +90,8 @@ func (m authModeSelectionModel) Update(msg tea.Msg) (authModeSelectionModel, tea
 
 		// Select correct line to ensure model is synchronised
 		for i, a := range m.Items() {
-			if a.(authModeItem).id != msg.id {
+			a := listItemsToAuthModeItem(a)
+			if a.id != msg.id {
 				continue
 			}
 			m.Select(i)
@@ -114,7 +115,7 @@ func (m authModeSelectionModel) Update(msg tea.Msg) (authModeSelectionModel, tea
 			if item == nil {
 				return m, nil
 			}
-			authMode := item.(authModeItem)
+			authMode := listItemsToAuthModeItem(item)
 			cmd := selectAuthMode(authMode.id)
 			return m, cmd
 		case "1", "2", "3", "4", "5", "6", "7", "8", "9":
@@ -125,7 +126,7 @@ func (m authModeSelectionModel) Update(msg tea.Msg) (authModeSelectionModel, tea
 				return m, nil
 			}
 			item := items[choice-1]
-			authMode := item.(authModeItem)
+			authMode := listItemsToAuthModeItem(item)
 			cmd := selectAuthMode(authMode.id)
 			return m, cmd
 		}
@@ -230,3 +231,12 @@ func getAuthenticationModes(client authd.PAMClient, sessionID string) tea.Cmd {
 func (m *authModeSelectionModel) Reset() {
 	m.currentAuthModeSelectedID = ""
 }
+
+// listItemsToAuthModeItem panics if item is not an authModeItem (programming error).
+func listItemsToAuthModeItem(item list.Item) authModeItem {
+	r, ok := item.(authModeItem)
+	if !ok {
+		panic(fmt.Sprintf("expected authModeItem, got %T", r))
+	}
+	return r
+}

pam/authorization.go

@@ -97,7 +97,6 @@ func (m *authorizationModel) Init() tea.Cmd {
 // Update handles events and actions.
 func (m *authorizationModel) Update(msg tea.Msg) (authorizationModel, tea.Cmd) {
 	switch msg := msg.(type) {
-
 	case reselectAuthMode:
 		m.cancelIsAuthorized()
 		return *m, sendEvent(AuthModeSelected{})
@@ -143,7 +142,11 @@ func (m *authorizationModel) Update(msg tea.Msg) (authorizationModel, tea.Cmd) {
 	var model tea.Model
 	if m.currentModel != nil {
 		model, cmd = m.currentModel.Update(msg)
-		m.currentModel = model.(authorizationComponent)
+		c, ok := model.(authorizationComponent)
+		if !ok {
+			panic(fmt.Sprintf("expected authorizationComponent, got %T", c))
+		}
+		m.currentModel = c
 	}
 	return *m, cmd
 }
@@ -240,6 +243,8 @@ func dataToMsg(data string) string {
 }
 
 // dataToUserInfo returns the user information from a given JSON string.
+//
+//nolint:unused // This is not used for now TODO
 func dataToUserInfo(data string) string {
 	/*v := make(map[string]string)
 	if err := json.Unmarshal([]byte(data), &v); err != nil {

pam/brokerselection.go

@@ -92,7 +92,8 @@ func (m brokerSelectionModel) Update(msg tea.Msg) (brokerSelectionModel, tea.Cmd
 		}
 		// Select correct line to ensure model is synchronised
 		for i, b := range m.Items() {
-			if b.(brokerItem).id != broker.Id {
+			b := listItemsToBrokerItem(b)
+			if b.id != broker.Id {
 				continue
 			}
 			m.Select(i)
@@ -116,7 +117,7 @@ func (m brokerSelectionModel) Update(msg tea.Msg) (brokerSelectionModel, tea.Cmd
 			if item == nil {
 				return m, nil
 			}
-			broker := item.(brokerItem)
+			broker := listItemsToBrokerItem(item)
 			cmd := selectBroker(broker.id)
 			return m, cmd
 		case "1", "2", "3", "4", "5", "6", "7", "8", "9":
@@ -127,7 +128,7 @@ func (m brokerSelectionModel) Update(msg tea.Msg) (brokerSelectionModel, tea.Cmd
 				return m, nil
 			}
 			item := items[choice-1]
-			broker := item.(brokerItem)
+			broker := listItemsToBrokerItem(item)
 			cmd := selectBroker(broker.id)
 			return m, cmd
 		}
@@ -138,7 +139,9 @@ func (m brokerSelectionModel) Update(msg tea.Msg) (brokerSelectionModel, tea.Cmd
 	return m, cmd
 }
 
-// Focus focuses this model.
+// Focus focuses this model. It always returns nil.
+//
+//nolint:unparam // Always returns nil.
 func (m *brokerSelectionModel) Focus() tea.Cmd {
 	m.focused = true
 	return nil
@@ -183,7 +186,7 @@ func (m brokerSelectionModel) WillCaptureEscape() bool {
 	return m.FilterState() == list.Filtering
 }
 
-// brokerItem
+// brokerItem is the list item corresponding to a broker.
 type brokerItem struct {
 	id   string
 	name string
@@ -206,7 +209,6 @@ func (d itemLayout) Update(_ tea.Msg, _ *list.Model) tea.Cmd { return nil }
 
 // Render writes to w the rendering of the items based on its selection and type.
 func (d itemLayout) Render(w io.Writer, m list.Model, index int, item list.Item) {
-
 	var label string
 	switch item := item.(type) {
 	case brokerItem:
@@ -258,3 +260,13 @@ func brokerFromID(brokerID string, brokers []*authd.ABResponse_BrokerInfo) *auth
 	}
 	return nil
 }
+
+// listItemsToBrokerItem panics if item is not an brokerItem (programming error).
+// TODO: transform to generic?
+func listItemsToBrokerItem(item list.Item) brokerItem {
+	r, ok := item.(brokerItem)
+	if !ok {
+		panic(fmt.Sprintf("expected brokerItem, got %T", r))
+	}
+	return r
+}

pam/formmodel.go

@@ -102,7 +102,12 @@ func (m formModel) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 		}
 		var newModel tea.Model
 		newModel, cmd = fm.Update(msg)
-		m.focusableModels[i] = newModel.(authorizationComponent)
+		// it should be a authorizationComponent, otherwise it’s a programming error.
+		c, ok := newModel.(authorizationComponent)
+		if !ok {
+			panic(fmt.Sprintf("expected authorizationComponent, got %T", c))
+		}
+		m.focusableModels[i] = c
 	}
 
 	return m, cmd

pam/model.go

@@ -11,7 +11,7 @@ import (
 
 var debug string
 
-// state represents the stage object
+// state represents the stage object.
 type stage int
 
 const (
@@ -47,7 +47,7 @@ type model struct {
 	authModeSelectionModel authModeSelectionModel
 	authorizationModel     authorizationModel
 
-	exitMsg error
+	exitMsg ExitMsger
 }
 
 /* global events */

pam/pam.go

@@ -89,23 +89,23 @@ func pam_sm_authenticate(pamh *C.pam_handle_t, flags, argc C.int, argv **C.char)
 	case pamSuccess:
 		return C.PAM_SUCCESS
 	case pamIgnore:
-		if exitMsg.Error() != "" {
+		if exitMsg.ExitMsg() != "" {
 			log.Debugf(context.TODO(), "Ignoring authd authentication: %v", exitMsg)
 		}
 		logErrMsg = ""
 		errCode = C.PAM_IGNORE
 	case pamAbort:
-		if exitMsg.Error() != "" {
+		if exitMsg.ExitMsg() != "" {
 			logErrMsg = fmt.Sprintf("cancelled authentication: %v", exitMsg)
 		}
 		errCode = C.PAM_ABORT
 	case pamAuthError:
-		if exitMsg.Error() != "" {
+		if exitMsg.ExitMsg() != "" {
 			logErrMsg = fmt.Sprintf("authentication: %v", exitMsg)
 		}
 		errCode = C.PAM_AUTH_ERR
 	case pamSystemError:
-		if exitMsg.Error() != "" {
+		if exitMsg.ExitMsg() != "" {
 			logErrMsg = fmt.Sprintf("system: %v", exitMsg)
 		}
 		errCode = C.PAM_SYSTEM_ERR

pam/return.go

@@ -2,11 +2,17 @@ package main
 
 // Various signalling return messaging to PAM.
 
+// ExitMsger is the exit message type and optional accompagning details.
+type ExitMsger interface {
+	ExitMsg() string
+}
+
 // pamSuccess signals PAM module to return PAM_SUCCESS and Quit tea.Model.
 type pamSuccess struct {
 }
 
-func (err pamSuccess) Error() string {
+// ExitMsg returns the string of pamSuccess.
+func (err pamSuccess) ExitMsg() string {
 	return ""
 }
 
@@ -15,8 +21,8 @@ type pamIgnore struct {
 	msg string
 }
 
-// Error returns the string of pamIgnore message.
-func (err pamIgnore) Error() string {
+// ExitMsg returns the string of pamIgnore message.
+func (err pamIgnore) ExitMsg() string {
 	return err.msg
 }
 
@@ -25,18 +31,18 @@ type pamAbort struct {
 	msg string
 }
 
-// Error returns the string of pamAbort message.
-func (err pamAbort) Error() string {
+// ExitMsg returns the string of pamAbort message.
+func (err pamAbort) ExitMsg() string {
 	return err.msg
 }
 
-// pamSystemError signals PAM module to return PAM_SYSTEM_ERROR and Quit tea.Model
+// pamSystemError signals PAM module to return PAM_SYSTEM_ERROR and Quit tea.Model.
 type pamSystemError struct {
 	msg string
 }
 
-// Error returns the string of pamSystemError message.
-func (err pamSystemError) Error() string {
+// ExitMsg returns the string of pamSystemError message.
+func (err pamSystemError) ExitMsg() string {
 	return err.msg
 }
 
@@ -45,7 +51,7 @@ type pamAuthError struct {
 	msg string
 }
 
-// Error returns the string of pamAuthError message.
-func (err pamAuthError) Error() string {
+// ExitMsg returns the string of pamAuthError message.
+func (err pamAuthError) ExitMsg() string {
 	return err.msg
 }