Lock mutex when reading isAuthorizedCalls map

internal/testutils/broker.go

@@ -38,7 +38,7 @@ type isAuthorizedCtx struct {
 type BrokerBusMock struct {
 	name                string
 	isAuthorizedCalls   map[string]isAuthorizedCtx
-	isAuthorizedCallsMu sync.Mutex
+	isAuthorizedCallsMu sync.RWMutex
 }
 
 // StartBusBrokerMock starts the D-Bus service and exports it on the system bus.
@@ -57,7 +57,7 @@ func StartBusBrokerMock(t *testing.T) string {
 	bus := BrokerBusMock{
 		name:                brokerName,
 		isAuthorizedCalls:   map[string]isAuthorizedCtx{},
-		isAuthorizedCallsMu: sync.Mutex{},
+		isAuthorizedCallsMu: sync.RWMutex{},
 	}
 	err = conn.Export(&bus, dbus.ObjectPath(busObjectPath), busInterface)
 	require.NoError(t, err, "Setup: could not export mock broker")
@@ -216,9 +216,13 @@ func (b *BrokerBusMock) IsAuthorized(sessionID, authenticationData string) (acce
 	}
 
 	// Handles the context that will be assigned for the IsAuthorized handler
+	b.isAuthorizedCallsMu.RLock()
 	if _, exists := b.isAuthorizedCalls[sessionID]; exists {
+		b.isAuthorizedCallsMu.RUnlock()
 		return "", "", dbus.MakeFailedError(fmt.Errorf("Broker %q: IsAuthorized already running for session %q", b.name, sessionID))
 	}
+	b.isAuthorizedCallsMu.RUnlock()
+
 	ctx, cancel := context.WithCancel(context.Background())
 	b.isAuthorizedCallsMu.Lock()
 	b.isAuthorizedCalls[sessionID] = isAuthorizedCtx{ctx, cancel}