Initial implementation for the ExampleBroker bus and the dbus communication with the daemon #3
Conversation
| <method name="SelectAuthenticationMode"> | ||
| <arg type="s" direction="in" name="requestID"/> |
There was a problem hiding this comment.
An other option here, instead of using a request ID would be to instead make this method to return a /com/ubuntu/auth/ExampleBroker/AuthMode/$ID/ object and that then provides the IsAuthorized() and CancelRequest methods.
So basically so you separate the BrokerManager from the BrokerAuthenticationObject.
There was a problem hiding this comment.
Hey @3v1n0. thanks for the suggestion! This interface definition was before we decided on how to handle the canceling part of the authentication process. Now that #4 is merged, only the sessionID is enough for us to know which request should be canceled.
However, it's still a very nice suggestion and we will probably draft something around it to see how it would look. Thanks!
denisonbarbosa
force-pushed
the
examplebroker-bus
branch
2 times, most recently
from
3bfb4e2
to
d206208
Compare
|
Hum, didn’t we decided to do the cleanup before this PR so that the diff is easier to navigate? Things like supportedUiLayouts -> supportedUILayouts, and so on? |
I thought the cleanup would come after this PR, since this one was already opened (and since you've mentioned that you wanted to show the dbus stuff to Okta on Monday), but I can do the housekeeping first if you prefer. |
I stated the opposite. I think having this PR smaller will really help! |
denisonbarbosa
force-pushed
the
examplebroker-bus
branch
2 times, most recently
from
9df0f6a
to
713f8ed
Compare
The dbusbroker represents what the daemon knows about a dbus broker. It is responsible for creating and making the dbus calls to the right interface and method, handle the response and return the desired values back to our daemon
This is the bus that will receive the calls for the ExampleBroker, call the apropriate broker function to handle them and then send the requested values through the bus again back to the dbusbroker caller.
denisonbarbosa
force-pushed
the
examplebroker-bus
branch
from
713f8ed
to
a2f04d3
Compare
- ExampleBroker: configuration file that will be parsed by authd to register the broker; - .conf: bus configuration file that specifies access policies for the bus; - .xml: defines the bus interface and its methods; - .sh: copies the files to the right places to make our life easier;
Now examplebroker is an internal package with all of its config files and the dbus mapping
denisonbarbosa
force-pushed
the
examplebroker-bus
branch
from
a2f04d3
to
7ec8e46
Compare
Up until now, we only had the example broker running locally since we didn't have the
dbusintegration with the daemon. This PR implements thedbuscalls and the ExampleBroker bus that will handle them.UDENG-1064