fix(pam): Start broker and user selection only if required, without touching terminal #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion should be done When this happens we should switch to the broker selection model
3v1n0
force-pushed
the
start-broker-selection-only-if-required
branch
2 times, most recently
from
6e79d00
to
b975910
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #316 +/- ##
==========================================
+ Coverage 84.51% 84.54% +0.02%
==========================================
Files 82 82
Lines 6227 6230 +3
Branches 79 79
==========================================
+ Hits 5263 5267 +4
+ Misses 671 670 -1
Partials 293 293 ☔ View full report in Codecov by Sentry. |
Delay broker selection until something requires it, so that we don't need to write anything to the terminal if there's no need to select the broker
…d one In case we fail parsing the output better to consider it completely than to provide an empty output as the golden file
So we avoid writing at all in the terminal if user selection is not required, add tests to verify this behavior
3v1n0
force-pushed
the
start-broker-selection-only-if-required
branch
from
b975910
to
5077953
Compare
denisonbarbosa
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that terminal output is not touched unless we really need to.
This is something that is also required for #314 so having it earlier would help that PR too.
UDENG-2608