Simplify PAM service tests #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn’t introduce some factoring in: client := newPamClient(t)
switch tc.sessionID {
case "invalid-session":
case "-":
tc.sessionID = ""
default:
id := startSession(t, client, tc.username)
if tc.sessionID == "" {
tc.sessionID = id
}
}simply because it’s used 4 times on the 8 |
This test ensure that we can successfully initialize a PAM service.
The no broker is actually no valid session ID. Simplify the tests to only have one element to set that behaviour. Use then a switch function which is more natural.
didrocks
force-pushed
the
simplify-tests
branch
from
ee5629a
to
851ce3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before introducing the cache in PAM service, let’s simplify the tests even more.