fix(pam): Fix supported UI layout for the QR Code #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The additional code entry in the layout must be optional, not required. Otherwise this invalidates QR Codes that do not have any code associated with them.
denisonbarbosa
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #395 +/- ##
==========================================
- Coverage 85.24% 85.08% -0.17%
==========================================
Files 76 76
Lines 6161 6161
Branches 75 75
==========================================
- Hits 5252 5242 -10
- Misses 644 649 +5
- Partials 265 270 +5 ☔ View full report in Codecov by Sentry. |
|
I agree, it wasn't spotted in #387 probably because there it was made optional in the commit I had later removed which made things optional depending on a parameter (for testing purposes). However, I think we need to check on validation because using this with the old broker it just worked... |
3v1n0
approved these changes
Jun 26, 2024
|
Just a nit, in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The additional code entry in the layout must be optional, not required. Otherwise, this invalidates QR Codes with no code associated with them.