fix(cache): Do not change homedir for user that already exists #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #399 +/- ##
==========================================
+ Coverage 85.24% 85.31% +0.07%
==========================================
Files 76 76
Lines 6161 6164 +3
Branches 75 75
==========================================
+ Hits 5252 5259 +7
+ Misses 644 642 -2
+ Partials 265 263 -2 ☔ View full report in Codecov by Sentry. |
didrocks
reviewed
Jun 27, 2024
denisonbarbosa
force-pushed
the
prevent-homedir-change
branch
from
d593205
to
f47d69e
Compare
We used to update every part of the user information in cache, but this can create problems if the admin changes the homedir configuration in the broker side, since it would update the homedir parsing for the user and, thus, "losing" access to the previous one.
denisonbarbosa
force-pushed
the
prevent-homedir-change
branch
from
437ecee
to
215739a
Compare
GabrielNagy
approved these changes
Jun 27, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to update every part of the user information in the cache but this can create problems if the admin changes the homedir configuration on the broker side, since it would update the homedir parsing for the user resulting in PAM creating a new one for the user at login.
UDENG-3125