Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint(pam/integration-tests): Add native QRCode tests and ensure they run as different users #401

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

3v1n0
Copy link
Collaborator

@3v1n0 3v1n0 commented Jun 27, 2024

Some tests changes that were supposed part of #314 and got lost due to pre-merging of #393

But I also will use those assumptions in an upcoming branch.

…ypes

This was intended to be part of ubuntu#314 but it got lost when merging with ubuntu#393
They share the same logic and tape but it's better to use different users
in order to ensure we're using different sessions
@3v1n0 3v1n0 requested a review from a team as a code owner June 27, 2024 15:55
Copy link
Collaborator Author

@3v1n0 3v1n0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good from my side, thanks!

Maybe we should consider making the also native interface similar to this when asking for secret, but that's indeed not for now.

Not sure why I can't approve though 🤔

@3v1n0
Copy link
Collaborator Author

3v1n0 commented Jun 27, 2024

All good from my side, thanks!

Maybe we should consider making the also native interface similar to this when asking for secret, but that's indeed not for now.

Not sure why I can't approve though 🤔

LOL I though I was replying to #394 since I had both tab opened :-D

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.27%. Comparing base (5132a3f) to head (2a77342).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #401      +/-   ##
==========================================
- Coverage   85.31%   84.27%   -1.04%     
==========================================
  Files          76       77       +1     
  Lines        6161     6676     +515     
  Branches       75       75              
==========================================
+ Hits         5256     5626     +370     
- Misses        642      735      +93     
- Partials      263      315      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@didrocks didrocks merged commit 05ca163 into ubuntu:main Jun 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants