fix(nss): Improve NSS error logs #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NSS error messages were definitely lacking useful information due to missing data on the grpc Error. This improves the messages by a considerable amount by printing the actual value the module is querying for and the return status of the request.
denisonbarbosa
force-pushed
the
improve-nss-errors
branch
from
5b6741f
to
11dec5b
Compare
3v1n0
approved these changes
Jun 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #403 +/- ##
==========================================
+ Coverage 84.40% 84.42% +0.02%
==========================================
Files 77 77
Lines 6686 6691 +5
Branches 75 75
==========================================
+ Hits 5643 5649 +6
+ Misses 732 730 -2
- Partials 311 312 +1 ☔ View full report in Codecov by Sentry. |
didrocks
approved these changes
Jul 1, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSS error messages lacked useful information due to missing data on the GRPC error. This improves the messages by a considerable amount by printing the actual value the module is querying for and the return status of the request.
Now we go from messages like:
To:
UDENG-3410