fix: remove comment from authd pam module to make it enable by default #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Authd was not registered by pam-auth-update automatically due to the comment which is unsupported by this tool. One a blank machine, which never got the request, this will now enable it by default. There is no format supporting comments unfortunately after reading the upstream perl source. UDENG-3408
|
Sad... But well, I hope the commit messages will remember us the rationale in future! |
Let me add a comment to remind us to not add a comment :p |
3v1n0
approved these changes
Jul 1, 2024
didrocks
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #404 +/- ##
==========================================
- Coverage 84.40% 84.27% -0.13%
==========================================
Files 77 77
Lines 6686 6691 +5
Branches 75 75
==========================================
- Hits 5643 5639 -4
- Misses 732 735 +3
- Partials 311 317 +6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authd was not registered by pam-auth-update automatically due to the comment which is unsupported by this tool.
One a blank machine, which never got the request, this will now enable it by default.
There is no format supporting comments unfortunately after reading the upstream perl source.
UDENG-3408