feat(pam/nativemodel): Do not render qrcode but show uri only in pkexec #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3v1n0
force-pushed
the
qrcode-show-uri-only-pkexec
branch
from
d6d655e
to
42ea6a3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #405 +/- ##
==========================================
+ Coverage 84.38% 84.47% +0.09%
==========================================
Files 77 77
Lines 6713 6733 +20
Branches 75 75
==========================================
+ Hits 5665 5688 +23
+ Misses 734 731 -3
Partials 314 314 ☔ View full report in Codecov by Sentry. |
denisonbarbosa
approved these changes
Jul 2, 2024
3v1n0
force-pushed
the
qrcode-show-uri-only-pkexec
branch
from
6c258ea
to
1b3a0af
Compare
Send the qrcode info message as a single item so that UIs such as GNOME shell can handle this properly
3v1n0
force-pushed
the
qrcode-show-uri-only-pkexec
branch
from
1b3a0af
to
cbe6f3b
Compare
|
Rebased updating the golden file to respect the changes in #408 |
denisonbarbosa
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not include qrcode in polkit UI
UDENG-3422