feat(qrcodemodel): Always include the content URI to the output #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #407 +/- ##
==========================================
- Coverage 84.42% 84.33% -0.10%
==========================================
Files 77 77
Lines 6691 6696 +5
Branches 75 75
==========================================
- Hits 5649 5647 -2
- Misses 730 733 +3
- Partials 312 316 +4 ☔ View full report in Codecov by Sentry. |
3v1n0
changed the title
|
Rebasing this to handle conflicts... |
In some cases (e.g. small terminals, tty's) the qrcode is not properly rendered or is not fully visible, so make the URI to be always written so that it can be used also without a qrcode scanner
didrocks
approved these changes
Jul 3, 2024
denisonbarbosa
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases (e.g. small terminals, tty's) the qrcode is not properly
rendered or is not fully visible, so make the URI to be always written
so that it can be used also without a qrcode scanner
UDENG-3324