cleanup(pam/integration-tests/cli): Do not build the module and pam clients for each test #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r each test Since commit d1a75d8, for the cli tests we call prepareClientTest() for each test in order to get the client folder, however this also implies building the test client, the module and the exec client for each test even though this is not needed, since we can share those binaries. So just call this once in the main test.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #409 +/- ##
==========================================
+ Coverage 84.39% 84.48% +0.08%
==========================================
Files 77 77
Lines 6691 6691
Branches 75 75
==========================================
+ Hits 5647 5653 +6
+ Misses 732 728 -4
+ Partials 312 310 -2 ☔ View full report in Codecov by Sentry. |
denisonbarbosa
approved these changes
Jul 2, 2024
didrocks
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since commit d1a75d8, for the cli tests we call prepareClientTest() for each test in order to get the client folder, however this also implies building the test client, the module and the exec client for each test even though this is not needed, since we can share those binaries.
So just call this once in the main test.
Ideally this should make CI a little quicker.
UDENG-3506