cleanup: Generate proto with go generate only if proto tag is provided
#411
Conversation
Avoids generating proto files unless explicitly requested. As per this it's now an error if the generation script is called during package build.
There was a problem hiding this comment.
I don’t think we want that.
go generate should always generate as per description. We should skip the generation during package build.
Then, we are using generate here to build the pam module, which is wrong and should be in the debian/rules makefile. We may need to add a build system for nss/pam in the future, but not for now.
|
So, you prefer the status quo better? I'm fine either way... Indeed we could build the module differently, but in the past it was built this way and during the various iterations we've always kept the ability to build the module in a single way everywhere, so that we had not to control too many ways to build it. Personally I agree we should have a proper build system for such things. |
Avoids generating proto files unless explicitly requested.
As per this it's now an error if the generation script is called during package build.
UDENG-3507