Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: contributing how to build #412

Merged
merged 5 commits into from
Jul 4, 2024
Merged

docs: contributing how to build #412

merged 5 commits into from
Jul 4, 2024

Conversation

jibel
Copy link
Contributor

@jibel jibel commented Jul 3, 2024

Expanded the TODOs to proper build documentation plus some other minor fixes.

Instructions have been tested on a clean 24.04 system.

UDENG-3430

@jibel jibel marked this pull request as ready for review July 3, 2024 15:08
@jibel jibel requested a review from a team as a code owner July 3, 2024 15:08
Copy link
Collaborator

@3v1n0 3v1n0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, a part few nits, the PAM side is incomplete since we rely also on the executable that is what actually does the job.

Not sure if we should also mention how service files should be generated / copied, but it's not strictly about building.

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@3v1n0 3v1n0 linked an issue Jul 3, 2024 that may be closed by this pull request
2 tasks
Copy link
Member

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have 2 small requests to ensure we don’t vendor and stuck Rust dependencies forever and that we install the correct dependencies for code generation.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Add mention to authd-pam

Co-authored-by: Marco Trevisan <[email protected]>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.46%. Comparing base (d000437) to head (604bab5).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
+ Coverage   84.38%   84.46%   +0.07%     
==========================================
  Files          77       77              
  Lines        6691     6693       +2     
  Branches       75       75              
==========================================
+ Hits         5646     5653       +7     
+ Misses        731      730       -1     
+ Partials      314      310       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jibel jibel requested a review from didrocks July 4, 2024 12:20
Copy link
Member

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@jibel jibel merged commit 80aaebe into main Jul 4, 2024
6 checks passed
@jibel jibel deleted the contributing_how_to_build branch July 4, 2024 12:27
@edibotopic edibotopic requested review from edibotopic and removed request for edibotopic July 4, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue: how to compile?
4 participants