Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: downgrade NSS lib errors to info #413

Merged
merged 2 commits into from
Jul 4, 2024
Merged

maint: downgrade NSS lib errors to info #413

merged 2 commits into from
Jul 4, 2024

Conversation

didrocks
Copy link
Member

@didrocks didrocks commented Jul 4, 2024

That way, we don’t spam logs for 3rd party applications using our library as they are the one which should control the output to the user. We send back those errors in a NSS format anyway to the caller already.

We thus only print details when AUTHD_NSS_INFO=stderr is set.

UDENG-3409

That way, we don’t spam logs for 3rd party applications using our
library as they are the one which should control the output to the user.
We send back those errors in a NSS format anyway to the caller already.

We thus only print details when AUTHD_NSS_INFO=stderr is set.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 84.32%. Comparing base (684d267) to head (e6419d6).
Report is 3 commits behind head on main.

Files Patch % Lines
nss/src/group/mod.rs 66.66% 3 Missing ⚠️
nss/src/passwd/mod.rs 66.66% 3 Missing ⚠️
nss/src/shadow/mod.rs 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #413      +/-   ##
==========================================
- Coverage   84.38%   84.32%   -0.07%     
==========================================
  Files          77       77              
  Lines        6688     6692       +4     
  Branches       75       75              
==========================================
- Hits         5644     5643       -1     
- Misses        732      733       +1     
- Partials      312      316       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@didrocks didrocks marked this pull request as ready for review July 4, 2024 08:53
@didrocks didrocks requested a review from a team as a code owner July 4, 2024 08:53
nss/src/logs/mod.rs Outdated Show resolved Hide resolved
Copy link
Member

@denisonbarbosa denisonbarbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on the Rust'ing! Well done!

@didrocks didrocks merged commit 67a9d45 into main Jul 4, 2024
6 checks passed
@didrocks didrocks deleted the do_not_spam_logs branch July 4, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants