Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update dependabot config #55

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Conversation

denisonbarbosa
Copy link
Member

Doing some improvements on the dependabot config file to prefix the bump commits with our new pull request naming standards.

@denisonbarbosa denisonbarbosa requested a review from a team as a code owner September 22, 2023 13:07
Copy link
Member

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind searching github for some example of those config and look at the output on the PR? I’m unsure about the scope parameter. The prefix ones match our discussion :)

@@ -11,21 +11,33 @@ updates:
directory: "/"
schedule:
interval: "daily"
commit-message:
include: scope
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure we need the scope here? It seems we already have a scope and will end up with deps(ci)(foo-dep): Bump blablabla from what I see in the doc

Copy link
Member Author

@denisonbarbosa denisonbarbosa Sep 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's it...
In the documentation, you can see the example:

- package-ecosystem: "pip"
  directory: "/"
  schedule:
    interval: "weekly"
  # Include a list of updated dependencies
  # with a prefix determined by the dependency group
  commit-message:
    prefix: "pip prod"
    prefix-development: "pip dev"
    include: "scope"

And they state that the resulting commit message will be: pip dev: bump requests from 1.0.0 to 1.0.1. So it matches what we want to happen.

Doing some improvements on the dependabot config file to prefix the bump
commits with our new pull request naming standards.
Copy link
Member

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s give it a try!

@denisonbarbosa denisonbarbosa merged commit 64a95c2 into main Sep 22, 2023
6 checks passed
@denisonbarbosa denisonbarbosa deleted the update-dependabot-config branch September 22, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants