Empty definition from google #6
Conversation
Instead of using our own, use the google one in the predefined repository.
|
Converting to draft, it seems that we are not using the correct version of protoc in CI. This needs to be digged in. |
|
Code generation now pass with the composite action always installing latest protoc: canonical/desktop-engineering@327efac. Let’s try to always roll with latest and revisit if we need to pin a given version at some point. |
There was a problem hiding this comment.
I wonder if it's worth it though... We are adding a new dependency to some packages in order to save a couple of lines in our proto file and it looks strange to have one of our service types separated in another place, no? This feels like "violating" one of the "goverbs" (a little copy is better than a little dependency)
|
After a good night of thoughts, I think you are right. This has more drawbacks than advantages. Well, at least, that allowed me to fix the generation action to take latest protoc available rather than the one in the current distro. Let’s withdraw. |
Instead of using our own, use the empty google message in the predefined repository.