fix(examplebroker): Mutliple fixes to example brokers #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the selection of userinfo, we missed the marker in the data json struct in the examplebroker. Readding it.
GabrielNagy
approved these changes
Sep 26, 2023
The examplebroker package is imported by brokers when using the "withexamplebroker" build tag. If we import the brokers pkg in the examplebroker one, we'll get a build error due to cycle imports.
We were not using the exampleUser type for anything (neither its Stringer implementation), so it's better to simplify things.
The user information should only be provided when we return auth.Granted
This is the ui layout used in other parts, let’s align with it.
didrocks
changed the title
Rename the variables to make more sense to reason with in example broker. Co-authored-by: Denison Barbosa <[email protected]>
denisonbarbosa
approved these changes
Sep 26, 2023
didrocks
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix missing userinfo metadata when granting access. In the selection of userinfo, we missed the marker in the data json struct in the examplebroker. Readding it.
Fix multiple MFAs handling logic.
Removal of dead code.
Fixing cycling imports.
Labels changes.