Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pam) Implement newpasswd view #64

Merged
merged 1 commit into from
Sep 27, 2023
Merged

feat(pam) Implement newpasswd view #64

merged 1 commit into from
Sep 27, 2023

Conversation

didrocks
Copy link
Member

The broker decides if the user needs to change his/her password. In this first iteration, we only support two fields that should match and basic error printing.
The view is optionally skippable.

DEENG-1180.

@didrocks didrocks force-pushed the newpasswd_view branch 3 times, most recently from aa5efc3 to da1dd16 Compare September 27, 2023 08:00
@didrocks didrocks marked this pull request as ready for review September 27, 2023 08:03
@didrocks didrocks requested a review from a team as a code owner September 27, 2023 08:03
The broker decides if the user needs to change his/her password. In this
first iteration, we only support two fields that should match and basic
error printing.
The view is optionally skippable.
var focusableModels []authenticationComponent
var passwordEntries []*textinputModel

// TODO: add digits and force validation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should definitely create a tracking list for all the //TODOS

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can easily do it with grep :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, but that implies that we'll remember to grep it 😂

Copy link
Member

@denisonbarbosa denisonbarbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@didrocks didrocks merged commit e337dcb into main Sep 27, 2023
5 checks passed
@didrocks didrocks deleted the newpasswd_view branch September 27, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants