Updating API to separate session handling from GetAuthenticationModes
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didrocks
requested changes
Aug 1, 2023
denisonbarbosa
commented
Aug 1, 2023
This change is to keep the naming aligned with the specification
We updated the API to separate the GetAuthenticationModes call from session handling, since (in order to support MFA) we need GAM to be called multiple times per session.
Since those are no-op, it's best to separate the diff from the broker that actually matters (for now).
We were not locking the mutexes when reading from the maps and this could result in races as well. Now we also check if the session still exists before modifying the map, otherwise we would just recreate it accidentaly Some variables were renamed for more consistency between the functions and their meaning
denisonbarbosa
force-pushed
the
update-api
branch
from
27cae89
to
0ff9466
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to start a new session and already return the supported authentication modes when the user selected a broker to use for authentication. In order to support MFA, we need to be able to call GetAuthenticationModes multiple times per session, which is not compatible with the way its currently implemented.
This PR splits
SelectBrokerinto two different methods:SelectBroker, which starts a new session for the specified user and associates a broker to the created session;GetAuthenticationModes, which fetches a list of supported authentication modes that are available for the given session;UDENG-1125