chore(es-proxy-scratch): Updated code to support scratch image#2687
Open
emalinowski wants to merge 2 commits intomasterfrom
Open
chore(es-proxy-scratch): Updated code to support scratch image#2687emalinowski wants to merge 2 commits intomasterfrom
emalinowski wants to merge 2 commits intomasterfrom
Conversation
Please find the detailed integration test report here Please find the ci env pod logs here |
nss10
requested changes
Dec 13, 2024
Contributor
nss10
left a comment
nss10
left a comment
There was a problem hiding this comment.
The rest looks good to me. Just one formatting change.
| echo ${i} >> "$credsFile" | ||
| done | ||
| g3kubectl delete secret aws-es-proxy || true | ||
| g3kubectl create secret generic aws-es-proxy "--from-file=credentials=${credsFile}" --from-literal=aws_access_key_id=$(cat creds.json| jq -r .es.aws_access_key_id) --from-literal=aws_secret_access_key=$(cat creds.json| jq -r .es.aws_secret_access_key) |
Contributor
There was a problem hiding this comment.
This could be a little more readable
g3kubectl create secret generic aws-es-proxy \
"--from-file=credentials=${credsFile}" \
--from-literal=aws_access_key_id=$(cat creds.json | jq -r .es.aws_access_key_id) \
--from-literal=aws_secret_access_key=$(cat creds.json | jq -r .es.aws_secret_access_key)
Please find the detailed integration test report here Please find the ci env pod logs here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Features
Updated code to support scratch es proxy images
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes