Feat/ssl andrzej #280
Open
Feat/ssl andrzej #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor multiple connection setups into one
… with org.elasticsearch.spark.sql format.
This reverts commit 381f9af.
…user" when no auth is used
…user" when no auth is used
Feat/ssl setup
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
Please find the detailed integration test report here Please find the ci env pod logs here |
BedfordWest
requested changes
Sep 9, 2024
| @@ -22,25 +21,28 @@ | |||
| DB_DATABASE = os.getenv("DB_DATABASE") or conf_data.get("db_database", "sheepdog") | |||
| DB_USERNAME = os.getenv("DB_USERNAME") or conf_data.get("db_username", "peregrine") | |||
| DB_PASSWORD = os.getenv("DB_PASSWORD") or conf_data.get("db_password", "unknown") | |||
| ENV_DB_USE_SSL_BOOL = os.getenv("DB_USE_SSL", "false") in ('true', '1', 't') | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one:
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes
Original PR:
#279