-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to MLS #16
Switch to MLS #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very well written! Almost as if you've done this before 😜
I noticed a few typos here and there, but otherwise this is looking great. I think I have a good idea how to implement this. The MLS part isn't super clear yet (as indicated by comment on section 6), but I'm sure that'll improve once I read more about it.
Signed-off-by: Brooklyn Zelenka <[email protected]>
Signed-off-by: Brooklyn Zelenka <[email protected]>
Signed-off-by: Brooklyn Zelenka <[email protected]>
Signed-off-by: Brooklyn Zelenka <[email protected]>
Signed-off-by: Brooklyn Zelenka <[email protected]>
I'm like 99% sure that this works from a spec perspective, but the one part that I wonder about is if we'll need to contriubte upstream to OpenMLS to allow UCANs at the credentials step. pub enum MlsCredentialType {
Basic(BasicCredential),
X509(Certificate),
}
pub struct BasicCredential {
identity: VLBytes,
} UCAN is like a much cleaned up and modernized X.509 (though formatted VERY differently). I think that we can hack it into the existing pub enum MlsCredentialType {
Basic(BasicCredential),
X509(Certificate),
Ucan(UcanCredential), // <---
} ...or more general... pub enum MlsCredentialType {
Basic(BasicCredential),
X509(Certificate),
Cutstom(CustomCert), // <---
}
pub struct CustomCert { // <---
certBytes: VLBytes, // <---
} 📚 Resources
|
👀 Preview
Changelog
Raw Tech
Formatting
Issues