v1.0.0-rc.1 #1
Open
v1.0.0-rc.1 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
reviewed
Aug 16, 2023
expede
commented
Oct 18, 2023
Comment on lines
+1
to
+10
| type RevocationAction <: Action { | ||
| cmd "ucan/revoke" | ||
| nnc "" | ||
| arg RevocationArguments | ||
| } | ||
|
|
||
| type RevocationArguments struct { | ||
| rev &Delegation | ||
| pth [&Delegation] | ||
| } |
There was a problem hiding this comment.
Even more things that I want from IPLD Schema ☝️
- Subtyping
- Concrete values
I'd even be happy extending...
nullablefor map values, list values, and struct fields
optionalfor struct fields
implicitfor struct fields -- in some representations
...with something like...
exactlyfor struct values
type JwtHeader struct {
typ String exactly "JWT"
alg String
Gozala
reviewed
Mar 22, 2024
| type RevocationArguments struct { | ||
| rev &Delegation | ||
| pth [&Delegation] | ||
| } |
There was a problem hiding this comment.
For the reference our currently deployed implementation uses ucan and proof field names as opposed to rev and pth see
Unless there is good reason to introduce a break here I would prefer not to, that said it's not a deal breaker just inconvenient.
Gozala
reviewed
Mar 22, 2024
| "revoke": {"/": "bafkreictzcfwelyww7zmjkl5nptyot24oilky2bppw42nui2acozhfmzqa"}, | ||
| "path": [ | ||
| {"/": "bafkreic4lzfu6gq6pxonmalbjzjumrs5p47plsolmccaz4qhgmzo24fagu"}, | ||
| {"/": bafkreicc3jmhhtkzv26rb43cfx6ihyjlj2hixdfrkirglrermfo6cduelm""} |
There was a problem hiding this comment.
Suggested change
| {"/": bafkreicc3jmhhtkzv26rb43cfx6ihyjlj2hixdfrkirglrermfo6cduelm""} | |
| {"/": "bafkreicc3jmhhtkzv26rb43cfx6ihyjlj2hixdfrkirglrermfo6cduelm""} |
Gozala
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview 📚
ucan-wg/spec