-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.0.0-rc.1 #1
base: main
Are you sure you want to change the base?
v1.0.0-rc.1 #1
Conversation
type RevocationAction <: Action { | ||
cmd "ucan/revoke" | ||
nnc "" | ||
arg RevocationArguments | ||
} | ||
|
||
type RevocationArguments struct { | ||
rev &Delegation | ||
pth [&Delegation] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even more things that I want from IPLD Schema ☝️
- Subtyping
- Concrete values
I'd even be happy extending...
nullable
for map values, list values, and struct fields
optional
for struct fields
implicit
for struct fields -- in some representations
...with something like...
exactly
for struct values
type JwtHeader struct {
typ String exactly "JWT"
alg String
type RevocationArguments struct { | ||
rev &Delegation | ||
pth [&Delegation] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the reference our currently deployed implementation uses ucan
and proof
field names as opposed to rev
and pth
see
Unless there is good reason to introduce a break here I would prefer not to, that said it's not a deal breaker just inconvenient.
"revoke": {"/": "bafkreictzcfwelyww7zmjkl5nptyot24oilky2bppw42nui2acozhfmzqa"}, | ||
"path": [ | ||
{"/": "bafkreic4lzfu6gq6pxonmalbjzjumrs5p47plsolmccaz4qhgmzo24fagu"}, | ||
{"/": bafkreicc3jmhhtkzv26rb43cfx6ihyjlj2hixdfrkirglrermfo6cduelm""} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{"/": bafkreicc3jmhhtkzv26rb43cfx6ihyjlj2hixdfrkirglrermfo6cduelm""} | |
{"/": "bafkreicc3jmhhtkzv26rb43cfx6ihyjlj2hixdfrkirglrermfo6cduelm""} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer name changes from what we have in live system, that said it is not a deal breaker just an inconvenience.
Other than that this is great and thank you so much for putting it together.
Preview 📚
ucan-wg/spec