Update SemVer handling & add 0.9.0 compat #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n 0.2.0, which uses "0.9.0-canary")
icidasset
reviewed
Jul 25, 2023
| @@ -53,7 +53,7 @@ export function handleCompatibility(header: unknown, payload: unknown): UcanPart | |||
|
|
|||
| // parse either the "ucv" or "uav" as a version in the header | |||
| // we translate 'uav: 1.0.0' into 'ucv: 0.3.0' | |||
| let version: "0.8.1" | "0.3.0" = "0.8.1" | |||
| let version: "0.9.1" | "0.3.0" = "0.9.1" | |||
There was a problem hiding this comment.
@blaine Not entirely sure what this does, does it set the default version to 0.9.1?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lib is deprecated, but pending wasm-based ts-ucan, we need compat with rs-ucan 0.2.0; this adds that support by implementing parsing of full semver tags including pre-release tags, and updates the ucan version to 0.9.1. In theory this shouldn't break anything? 🧐