Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add L1 Benchmarking #1
base: master
Are you sure you want to change the base?
Add L1 Benchmarking #1
Changes from all commits
55365ed
284dabe
afa397a
60aef70
a1338a5
7e529e2
16d82c6
a2402d9
d500223
8220621
67b14f1
e5e981c
7715229
c8b36e4
fb3174d
0dc6bf0
94d31cc
0707243
db320de
65307dd
5115d59
3d90bde
ddfcafd
1db88dc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a small description of what $1 and $2 are supposed to be pointing to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, this is running the test on
vvadd
. If we are going to add this, I think the benchmark should also be abstracted out.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of using a statically assigned boolean to control printing, this should be enabled by a
plusArg
.Then when running the sim just set
EXTRA_SIM_FLAGS=+prefetcher_print_stats=1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as comment above.