Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shallow clone all submodules #1064

Merged
merged 3 commits into from
Feb 16, 2022
Merged

Shallow clone all submodules #1064

merged 3 commits into from
Feb 16, 2022

Conversation

jerryz123
Copy link
Contributor

This might improve clone times.

Type of change: new feature

Impact: software change

Release Notes

Switch to shallow clone of all submodules

@jerryz123 jerryz123 force-pushed the shallow-all branch 5 times, most recently from 4781cd4 to aae76ef Compare December 17, 2021 22:01
Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jerryz123
Copy link
Contributor Author

Don't merge this yet. The commit on master tests are broken.

Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get this fixed before the next release?

@jerryz123 jerryz123 force-pushed the shallow-all branch 7 times, most recently from 506adfd to 632be20 Compare February 12, 2022 03:14
@abejgonzalez
Copy link
Contributor

Looks like CI is erroring because of actions/checkout#424.

@abejgonzalez abejgonzalez force-pushed the shallow-all branch 4 times, most recently from b0c15ce to 986e7e8 Compare February 15, 2022 17:36
@abejgonzalez abejgonzalez mentioned this pull request Feb 15, 2022
@abejgonzalez abejgonzalez changed the base branch from dev to skip-val-fix February 16, 2022 00:29
@abejgonzalez abejgonzalez changed the base branch from skip-val-fix to dev February 16, 2022 00:31
jerryz123 added a commit that referenced this pull request Mar 18, 2022
jerryz123 added a commit that referenced this pull request Mar 18, 2022
jerryz123 added a commit that referenced this pull request Mar 18, 2022
jerryz123 added a commit that referenced this pull request Apr 6, 2022
Don't shallow clone submodules (revert #1064)
@abejgonzalez abejgonzalez deleted the shallow-all branch April 15, 2022 23:12
jerryz123 added a commit that referenced this pull request Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants