-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GPU project chipyard changes #2190
Conversation
generators/chipyard/src/main/scala/config/RadianceConfigs.scala
Outdated
Show resolved
Hide resolved
Cool, except this seems to break the ClusteredRocketConfig 😢 |
chipsalliance/rocket-chip#3718 should fix this |
Can you add a CI test that builds+runs one of these configs? The test can be something very simple... just a hello world-like thing basically. |
Is using VCS an option? forgot our Vortex fails to build in Verilator |
Oh, in that case don't bother with testing the sim. You can just add a test that the verilog gets generated. |
Verilator fails to build sim binary, so just generate verilog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would ask you to add a docs page, but you can do that in a follow-on PR so we can get this monster in. Feel free to merge ... ignore the CI failures related to firesim
Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
main
as the base branch?changelog:<topic>
label?changelog:
label?.conda-lock.yml
file if you updated the conda requirements file?Please Backport
?CI Help:
Add the following labels to modify the CI for a set of features.
Generally, a label added only affect subsequent changes to the PR (i.e. new commits, force pushing, closing/reopening).
See
ci:*
for full list of labels:ci:fpga-deploy
- Run FPGA-based E2E testingci:local-fpga-buildbitstream-deploy
- Build local FPGA bitstreams for platforms that are releasedci:disable
- Disable CI