feat(primitives): revamp schematic primitives #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanku
commented
Aug 31, 2023
libs/scir/src/netlist.rs
Outdated
| @@ -128,9 +125,15 @@ pub enum NetlistPrimitiveDeviceKind<'a> { | |||
| /// Appropriate newlines will be added after each function call, so newlines added by | |||
| /// implementors may cause formatting issues. | |||
| pub trait SpiceLikeNetlister { | |||
There was a problem hiding this comment.
Need to modify this.
|
|
||
| #[derive(Clone, Copy, Hash, PartialEq, Eq, Serialize, Deserialize, Block)] | ||
| #[substrate(io = "VdividerIo", flatten)] | ||
| #[substrate(io = "VdividerIo", kind = "block::Cell")] |
There was a problem hiding this comment.
Add back flatten here.
| ) { | ||
| self.set_ic_inner(SimSignal::ScirVoltage(key.clone()), value); | ||
| } | ||
| } | ||
|
|
||
| impl SetInitialCondition<&NodePath, Decimal> for Options { | ||
| fn set_initial_condition(&mut self, key: &NodePath, value: Decimal, ctx: &SimulationContext) { | ||
| impl SetInitialCondition<&NodePath, Decimal, Spectre> for Options { |
There was a problem hiding this comment.
Find a unified API for these type of option modifiers.
rahulk29
reviewed
Sep 4, 2023
libs/scir/src/drivers.rs
Outdated
| @@ -205,10 +205,10 @@ impl LibraryBuilder { | |||
| .entered(); | |||
|
|
|||
| // Cannot validate blackbox cells. | |||
| if cell.contents().is_opaque() { | |||
| if cell.contents().is_blackbox() { | |||
There was a problem hiding this comment.
blackbox should be within-cell. replace current blackbox with external module.
rohanku
commented
Sep 5, 2023
| @@ -84,7 +88,7 @@ fn can_generate_flattened_vdivider_array_schematic() { | |||
| let vdiv3 = crate::shared::vdivider::flattened::Vdivider::new(20, 20); | |||
| let vdivs = vec![vdiv1, vdiv2, vdiv3]; | |||
| let vdivider = crate::shared::vdivider::flattened::VdividerArray { vdividers: vdivs }; | |||
| let RawLib { scir, conv: _ } = ctx.export_scir(vdivider).unwrap(); | |||
| let RawLib { scir, conv: _ } = ctx.export_scir::<Spice, _>(vdivider).unwrap(); | |||
There was a problem hiding this comment.
Is there a way to get rid of the _?
rahulk29
reviewed
Sep 7, 2023
libs/scir/src/lib.rs
Outdated
| @@ -913,7 +906,8 @@ impl LibraryBuilder { | |||
| } else { | |||
| instance_names.push(inst.name().clone()); | |||
| } | |||
| id = inst.cell(); | |||
| todo!() | |||
rahulk29
reviewed
Sep 7, 2023
substrate/src/pdk/primitives.rs
Outdated
| fn hash<H: Hasher>(&self, state: &mut H) { | ||
| self.cell.hash(state); | ||
| self.ports.hash(state); | ||
| self.params.iter().collect::<Vec<_>>().hash(state); |
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
rahulk29
reviewed
Nov 1, 2023
rahulk29
reviewed
Nov 1, 2023
rahulk29
approved these changes
Nov 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.