New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spice): refactor netlisting and fix voltage source netlist #316

Merged

rohanku merged 3 commits into main from spice-fixes

Nov 4, 2023

Contributor

rohanku commented Nov 4, 2023

start fixing spice and adding helper functions for netlisting
fix errors

rohanku added 3 commits

November 3, 2023 14:43


          start fixing spice and adding helper functions for netlisting

e07ca68


          fix errors


          delete extra files

7d4d05c

rahulk29 approved these changes

View reviewed changes

codecov bot commented Nov 4, 2023 •

edited

Loading

Codecov Report

Attention: 156 lines in your changes are missing coverage. Please review.

Files	Coverage Δ
libs/scir/src/lib.rs	`60.36% <100.00%> (+0.60%)`	⬆️
libs/scir/src/tests.rs	`14.64% <ø> (-6.59%)`	⬇️
libs/spice/src/lib.rs	`37.93% <ø> (+0.52%)`	⬆️
tools/ngspice/src/tran.rs	`40.31% <ø> (ø)`
tools/spectre/src/tran.rs	`50.79% <ø> (ø)`
tools/ngspice/src/lib.rs	`35.96% <50.00%> (+0.18%)`	⬆️
tools/spectre/src/lib.rs	`39.63% <25.00%> (+0.15%)`	⬆️
tests/src/hard_macro.rs	`20.27% <0.00%> (-1.65%)`	⬇️
tests/src/netlist.rs	`21.65% <0.00%> (-0.72%)`	⬇️
libs/spice/src/netlist.rs	`46.08% <40.81%> (ø)`
... and 1 more

... and 24 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

rohanku merged commit 7a3df69 into main

5 checks passed

rohanku deleted the spice-fixes branch

November 4, 2023 00:47

rohanku mentioned this pull request

chore: release main #317

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet