Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(simulation): add missing SPICE functionality and update Sky 130 PDK #336

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

rohanku
Copy link
Contributor

@rohanku rohanku commented Dec 3, 2023

No description provided.

Copy link

codecov bot commented Dec 3, 2023

Codecov Report

Attention: 74 lines in your changes are missing coverage. Please review.

Comparison is base (c9a8aea) 43.87% compared to head (64b7708) 43.94%.

Files Patch % Lines
libs/spice/src/parser/conv.rs 9.52% 10 Missing and 9 partials ⚠️
libs/spice/src/parser/mod.rs 16.66% 8 Missing and 7 partials ⚠️
libs/spice/src/parser/tests.rs 16.66% 1 Missing and 14 partials ⚠️
pdks/sky130pdk/src/lib.rs 21.05% 7 Missing and 8 partials ⚠️
libs/spice/src/netlist.rs 0.00% 5 Missing ⚠️
libs/spice/src/lib.rs 0.00% 2 Missing and 1 partial ⚠️
tools/ngspice/src/lib.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
+ Coverage   43.87%   43.94%   +0.06%     
==========================================
  Files         147      147              
  Lines       17357    17399      +42     
  Branches     7124     7176      +52     
==========================================
+ Hits         7616     7646      +30     
+ Misses       4249     4248       -1     
- Partials     5492     5505      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rohanku rohanku merged commit f802be5 into main Dec 3, 2023
5 checks passed
@rohanku rohanku deleted the spice-improvements branch December 3, 2023 18:47
@rohanku rohanku mentioned this pull request Dec 3, 2023
This was referenced Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants