Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(netlists): consistent Spectre/Spice netlist API #349

Merged
merged 3 commits into from
Dec 22, 2023

Conversation

rahulk29
Copy link
Contributor

fix(schemas): consistent use of optional sized bound for schemas
fix(docs): update docs, import trait in tests

@rahulk29 rahulk29 self-assigned this Dec 22, 2023
@rahulk29 rahulk29 requested a review from rohanku December 22, 2023 21:14
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (c85d043) 39.38% compared to head (76a010f) 39.38%.

Files Patch % Lines
substrate/src/error.rs 0.00% 3 Missing ⚠️
tools/spectre/src/lib.rs 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #349      +/-   ##
==========================================
- Coverage   39.38%   39.38%   -0.01%     
==========================================
  Files         162      162              
  Lines       20008    20014       +6     
  Branches     8388     8387       -1     
==========================================
+ Hits         7880     7882       +2     
- Misses       6650     6653       +3     
- Partials     5478     5479       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rahulk29 rahulk29 merged commit 2f9fabf into main Dec 22, 2023
5 checks passed
@rahulk29 rahulk29 deleted the spectre-netlist-api branch December 22, 2023 21:26
@rohanku rohanku mentioned this pull request Dec 22, 2023
This was referenced Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants