Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(atoll): implement first cut ATOLL implementation #357

Merged
merged 58 commits into from
Jan 7, 2024
Merged

Conversation

rahulk29
Copy link
Contributor

  • wip: atoll API
  • wip
  • basic port extraction

@rahulk29 rahulk29 self-assigned this Dec 28, 2023
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 698 lines in your changes are missing coverage. Please review.

Comparison is base (264d028) 39.54% compared to head (7575442) 40.93%.

Files Patch % Lines
libs/atoll/src/abs.rs 42.14% 90 Missing and 83 partials ⚠️
libs/atoll/src/lib.rs 41.20% 55 Missing and 72 partials ⚠️
tests/src/atoll/mod.rs 22.65% 6 Missing and 93 partials ⚠️
pdks/sky130pdk/src/atoll/mod.rs 58.59% 40 Missing and 54 partials ⚠️
libs/atoll/src/grid.rs 77.04% 27 Missing and 46 partials ⚠️
libs/atoll/src/route.rs 14.89% 10 Missing and 30 partials ⚠️
codegen/src/pdk/layers.rs 0.00% 30 Missing ⚠️
substrate/src/layout/element.rs 62.16% 10 Missing and 4 partials ⚠️
substrate/src/layout/tracks.rs 36.84% 2 Missing and 10 partials ⚠️
substrate/src/io/layout.rs 9.09% 8 Missing and 2 partials ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
+ Coverage   39.54%   40.93%   +1.38%     
==========================================
  Files         163      167       +4     
  Lines       20214    21136     +922     
  Branches     8471     8849     +378     
==========================================
+ Hits         7994     8652     +658     
+ Misses       6665     6604      -61     
- Partials     5555     5880     +325     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rohanku rohanku changed the base branch from main to atoll-api December 28, 2023 18:17
rahulk29 and others added 15 commits December 28, 2023 11:25
* basic port extraction

* feat(lvs-matching): LVS matching via AtollTile trait

* work on atoll api

* fix integer division rounding issues

* fix lints

* expose vec of net IDs from AtollAbstract

* wip api

* remove unecessary changes

---------

Co-authored-by: Rahul Kumar <[email protected]>
feat(atoll): fill sky130 nmos tile lcm bounds with nsdm and pwell

This allows proper abutment between nmos tiles.
The LayerBbox trait allows users to find bounding boxes
considering only the geometry on a specific LayerId.
feat(atoll): make abstract generator function part of Abstract
@rahulk29 rahulk29 changed the base branch from atoll-api to main December 31, 2023 02:56
@rohanku rohanku changed the title ATOLL abstract view generator feat(atoll): implement first cut ATOLL implementation Jan 4, 2024
@rahulk29 rahulk29 requested a review from rohanku January 7, 2024 01:19
@rahulk29 rahulk29 merged commit 372b927 into main Jan 7, 2024
5 checks passed
@rahulk29 rahulk29 deleted the abstract branch January 7, 2024 01:20
@rohanku rohanku mentioned this pull request Dec 23, 2023
This was referenced Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants