Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parser): parse negative numbers and exponents #364

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

rahulk29
Copy link
Contributor

Supports parsing numeric literals containing negative numbers and/or
exponents. For example, the SPICE parser now handles "-2", "-2.3",
"-2.34e-19", or "2.34e19".

Supports parsing numeric literals containing negative numbers and/or
exponents. For example, the SPICE parser now handles "-2", "-2.3",
"-2.34e-19", or "2.34e19".
@rahulk29 rahulk29 self-assigned this Jan 12, 2024
@rahulk29 rahulk29 requested a review from rohanku January 12, 2024 19:12
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (b74afa1) 40.73% compared to head (829348b) 40.69%.

Files Patch % Lines
libs/spice/src/parser/conv.rs 30.23% 6 Missing and 24 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #364      +/-   ##
==========================================
- Coverage   40.73%   40.69%   -0.04%     
==========================================
  Files         167      167              
  Lines       21255    21274      +19     
  Branches     8935     8947      +12     
==========================================
  Hits         8658     8658              
- Misses       6690     6693       +3     
- Partials     5907     5923      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rahulk29 rahulk29 merged commit 53c01f6 into main Jan 12, 2024
5 checks passed
@rahulk29 rahulk29 deleted the spice-parse-numeric-literals branch January 12, 2024 19:28
@rohanku rohanku mentioned this pull request Jan 12, 2024
This was referenced Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants