feat(atoll): require edge-centered tracks #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the offset field from `AbstractLayer`, making all tracks be centered at the origin.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #368 +/- ##
==========================================
+ Coverage 40.64% 40.85% +0.20%
==========================================
Files 167 167
Lines 21277 21275 -2
Branches 8943 8941 -2
==========================================
+ Hits 8649 8691 +42
- Misses 6697 6699 +2
+ Partials 5931 5885 -46 ☔ View full report in Codecov by Sentry. |
rohanku
approved these changes
Jan 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the offset field from
AbstractLayer, makingall tracks be centered at the origin.