Skip to content

Seed Leave Types in Test and Prod - #67

Merged
aristachauhan merged 1 commit into
mainfrom
abc/fix-faculty-emulation
Oct 9, 2026
Merged

aristachauhan merged 1 commit into
mainfrom
abc/fix-faculty-emulation

Conversation

@aristachauhan

@aristachauhan aristachauhan commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

closes #63

Summary by CodeRabbit

  • Updates
    • Required leave types are now available after database initialization, even when development data is not loaded. Existing entries are refreshed when their key details change.
  • Changes
    • Compensatory Time is no longer included among the supported leave categories.

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 13 functions across 3 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check Passed Issue [#63] requires five selectable leave types with exact labels. DbInitializer defines Vacation, Sick Leave, Professional Development, Sabbatical, and FMLA, and ensures these rows during initiali…
Out of Scope Changes check Passed The changes remain related to the leave-type catalog required by [#63]. The removal of Compensatory Time from leave-type handling aligns the catalog with the five labels required by the issue. The i…
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly summarizes the main change: seeding leave types in test and production environments.


  • Fix all pre-merge checks with AI
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@aristachauhan
aristachauhan marked this pull request as ready for review October 9, 2026 16:01
@aristachauhan
aristachauhan merged commit c64dbb0 into main Oct 9, 2026
4 checks passed
@aristachauhan
aristachauhan deleted the abc/fix-faculty-emulation branch October 9, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Leave type dropdown cannot be selected when emulating a faculty member

1 participant