Skip to content

Unsimplify shapely geometry#14

Merged
lispandfound merged 1 commit intomainfrom
unsimplify
Apr 7, 2025
Merged

Unsimplify shapely geometry#14
lispandfound merged 1 commit intomainfrom
unsimplify

Conversation

@lispandfound
Copy link
Collaborator

Earlier, we introduced geometry simplification into the DB generation process. Ultimately, I decided this is best done later on in the pipeline (i.e. by the consumer of database data). This is because you can't unsimplify the geometry after you've already simplified it.

@lispandfound
Copy link
Collaborator Author

Actually, the simplification is required to remove some planes from the DB that have zero length. I've lowered the simplification threshold down to 1m, which should be low enough to avoid this problem but not high enough to change anything significant.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the call to simplify geometry in the database generation pipeline so that consumers work with the full-fidelity fault trace geometries.

  • Removed the simplification step from the fault trace extraction process.
Comments suppressed due to low confidence (1)

nshmdb/scripts/nshm_db_generator.py:74

  • Removing the geometry simplification here means that downstream consumers must now handle full-precision fault traces. Please confirm that all consumers and tests have been updated to work with the unsimplified geometry.
fault_trace = shapely.simplify(fault_trace, 10)

@lispandfound lispandfound merged commit 0e14f24 into main Apr 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants