Merged
Conversation
Collaborator
Author
|
Actually, the simplification is required to remove some planes from the DB that have zero length. I've lowered the simplification threshold down to 1m, which should be low enough to avoid this problem but not high enough to change anything significant. |
There was a problem hiding this comment.
Pull Request Overview
This PR removes the call to simplify geometry in the database generation pipeline so that consumers work with the full-fidelity fault trace geometries.
- Removed the simplification step from the fault trace extraction process.
Comments suppressed due to low confidence (1)
nshmdb/scripts/nshm_db_generator.py:74
- Removing the geometry simplification here means that downstream consumers must now handle full-precision fault traces. Please confirm that all consumers and tests have been updated to work with the unsimplified geometry.
fault_trace = shapely.simplify(fault_trace, 10)
joelridden
approved these changes
Apr 2, 2025
AndrewRidden-Harper
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earlier, we introduced geometry simplification into the DB generation process. Ultimately, I decided this is best done later on in the pipeline (i.e. by the consumer of database data). This is because you can't unsimplify the geometry after you've already simplified it.