Merged
Conversation
Collaborator
Author
|
I've also added a full test run of the NSHMDB to the test suite to ensure that this cannot happen again. It, at this stage, just checks that you can generate a database. It'd be nice to actually extract this DB as a build artifact and publish a release every time it is merged to master. |
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
tests/test_nshmdb_generator.py:25
- [nitpick] Consider asserting that the warning message is produced when fault trace simplification occurs to improve test coverage for the new functionality.
def test_nshmdb_generator_runs(tmp_path: Path):
joelridden
approved these changes
Apr 7, 2025
AndrewRidden-Harper
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously I removed the shapely simplification. This change missed an additional change I made to do the only simplification that is actually necessary: removing repeated points in the fault trace. Without that necessary check the script will crash when generating a database. This PR adds the missing repeat point removal. This only affects one fault in the NSHMDB, Irishman Creek, Subsection 2. You now get a warning that some simplification has occurred, along with a diff of the simplified trace vs the old trace.
As you you can see, the fault trace in this instance has been simplified because the first point in the Irishman Creek fault matches the second point in the Irishman Creek fault. No other warnings should be produced in this generation.