Extra function for getting fault_ids

[claudio525]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @claudio525, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new utility function to the database interaction layer for fetching fault identifiers and adds a standard entry point to one of the database generation scripts.

Highlights

• New Database Method: Added a new public method get_fault_ids to the NSHMDB class in nshmdb/nshmdb.py. This method provides a convenient way to retrieve all fault_id values from the fault table in the database.
• Script Executability: Added the standard if __name__ == "__main__": app() block to nshmdb/scripts/nshm_db_generator.py, making the script directly executable from the command line.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new utility method get_fault_ids to the NSHMDB class for retrieving all unique fault IDs from the fault table. This method is consistent in implementation style with the existing get_fault_names. Additionally, the nshm_db_generator.py script is updated with a standard if __name__ == "__main__": guard, which is a commendable best practice for script execution and module importability. My primary feedback focuses on the potential memory implications of get_fault_ids if the fault table were to become extremely large, suggesting a consideration for future scalability.