Skip to content

Requirements update#2

Merged
joelridden merged 4 commits intomainfrom
requirements_update
Jan 11, 2026
Merged

Requirements update#2
joelridden merged 4 commits intomainfrom
requirements_update

Conversation

@joelridden
Copy link
Contributor

Updates requirements to versions
Fixes small bug with fetching new data with the addition of the John Townend dataset
Fetches data till the end of 2025

@gemini-code-assist
Copy link

Summary of Changes

Hello @joelridden, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on maintaining the project's data integrity and operational efficiency. It updates key external library requirements, resolves a data acquisition issue that arose with a new dataset, and ensures the latest available data is incorporated into the system.

Highlights

  • Dependency Updates: Updated qcore and source-modelling dependencies to specific versioned packages (qcore-utils>=2025.12.1 and source_modelling>=2025.12.1).
  • Data Fetching Bug Fix: Addressed a small bug encountered when fetching new data, specifically related to the integration of the John Townend dataset.
  • Data Refresh and Extension: The CMT solutions data has been refreshed and extended to include data up until the end of 2025.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates package requirements, fixes a data fetching bug, and refreshes the earthquake data. The code changes are positive, including the removal of commented-out code and the addition of a 'source' column to improve data traceability. Switching from git-based dependencies to versioned packages is a great step for better dependency management. I have one minor suggestion for requirements.txt to improve its clarity.

requirements.txt Outdated
Comment on lines +9 to +10
qcore-utils>=2025.12.1,
source_modelling>=2025.12.1, No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While pip can handle trailing commas in requirements.txt files, they are not standard and can be confusing. It's best practice to remove them for improved clarity and maintainability.

qcore-utils>=2025.12.1
source_modelling>=2025.12.1

@joelridden joelridden merged commit 119d8b1 into main Jan 11, 2026
3 checks passed
@joelridden joelridden deleted the requirements_update branch January 11, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant