Skip to content

New domain values#87

Merged
joelridden merged 8 commits into4p4from
new_domain_values
Jan 22, 2026
Merged

New domain values#87
joelridden merged 8 commits into4p4from
new_domain_values

Conversation

@joelridden
Copy link
Contributor

Adding kirans new domain values, with defaults going back to robins work when the tect class and mapping region do not match in kirans work.

Adds in the cmt_solutions repo to gather the cmt data as well as the reviewed data at the same time.

@gemini-code-assist
Copy link

Summary of Changes

Hello @joelridden, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the system's ability to determine earthquake source parameters by integrating new tectonic domain values and a dedicated cmt_solutions repository. The changes streamline the process of retrieving and applying Centroid Moment Tensor data, and introduce more sophisticated logic for selecting nodal planes based on tectonic class, ensuring more accurate and robust distance calculations, especially for events lacking direct CMT solutions.

Highlights

  • New Domain Values Integration: Incorporated new domain values from Kiran's work, with a fallback mechanism to Robin's previous work when the tectonic class and mapping region do not align with the new data.
  • CMT Solutions Repository: Integrated the cmt_solutions repository to centralize and retrieve both reviewed and unreviewed Centroid Moment Tensor (CMT) data more efficiently.
  • Nodal Plane Determination Logic: Refactored the logic for determining nodal planes, introducing get_crustal_domain_focal and updating get_nodal_plane_info to handle various tectonic classes (Crustal, Interface, Slab) and utilize new focal mechanism data for more robust calculations.
  • Data Registry Updates: Added several new data files, including updated tectonic domain shapefiles, Hikurangi and Puysegur focal mechanism data, and slab faulting geometry, to the data registry.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@joelridden joelridden marked this pull request as draft January 5, 2026 00:20
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces significant updates to the nodal plane determination logic by incorporating new domain values and data sources from Kiran's work. It correctly separates reviewed and unreviewed CMT data and adds a new cmt-solutions dependency. The logic for handling different tectonic classes (Crustal, Interface, Slab) is much more detailed, using various models and fallback mechanisms.

I've found a couple of critical issues that need to be addressed: a hardcoded file path that was likely left over from debugging, and a function call that is missing required arguments, which will cause a runtime error. I also pointed out an opportunity to improve maintainability by refactoring duplicated code into a helper function. Once these issues are resolved, this will be a solid contribution.

@joelridden joelridden marked this pull request as ready for review January 15, 2026 23:01
lispandfound
lispandfound previously approved these changes Jan 20, 2026
@joelridden joelridden merged commit 88fa713 into 4p4 Jan 22, 2026
5 checks passed
@joelridden joelridden deleted the new_domain_values branch January 22, 2026 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants