Conversation
Summary of ChangesHello @claudio525, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on preparing the Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates pyproject.toml to prepare the package for publishing on PyPI. The changes correctly switch to a standard hyphenated package name and set up dynamic versioning using setuptools-scm, which are great improvements for maintainability. However, there are a couple of critical issues in your dependencies that will prevent publishing to PyPI or cause issues for users of your package:
- Git Dependency:
requirements.txtcontains a direct dependency on a git repository (qcore @ git+...). Packages published to PyPI cannot have dependencies that are not also available on PyPI. - Test Dependencies:
requirements.txtalso includespytestandpytest-cov. These are development/testing dependencies and should not be included in the core dependencies of the package. Users of your library will be forced to install your testing tools, which is undesirable.
Both of these issues stem from using requirements.txt directly for your package dependencies. It's recommended to define your core dependencies directly in pyproject.toml under [project.dependencies] (or keep them in requirements.txt but remove the problematic ones) and move development dependencies to [project.optional-dependencies].
I've also included a suggestion to enhance how the package version is managed at runtime.
There was a problem hiding this comment.
Pull request overview
This PR configures the package for PyPI publishing by adding a GitHub Actions workflow and updating package metadata. The changes enable automated publishing to PyPI when releases are created, while also modernizing the versioning approach to use git tags via setuptools-scm.
- Adopts dynamic versioning using setuptools-scm instead of hardcoded versions
- Renames package from
pygmt_helpertopygmt-helper(following PyPI naming conventions with hyphens) - Updates dependency name from
qcoretoqcore-utilsin requirements
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/publish-PyPI.yml |
Adds GitHub Actions workflow to build and publish package to PyPI on release or manual trigger |
pyproject.toml |
Updates package name to use hyphens, removes hardcoded version in favor of dynamic versioning via setuptools-scm |
requirements.txt |
Renames qcore dependency to qcore-utils while maintaining git repository source |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.