Merged
Conversation
AndrewRidden-Harper
previously approved these changes
Mar 12, 2025
Contributor
Author
|
Tests will fail until ucgmsim/qcore#349 merges. |
joelridden
previously approved these changes
Mar 13, 2025
claudio525
previously approved these changes
Mar 13, 2025
Contributor
claudio525
left a comment
claudio525
left a comment
There was a problem hiding this comment.
Looks great, nice one!
joelridden
approved these changes
Mar 16, 2025
AndrewRidden-Harper
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small PR, just converts
NZMapDatato useqcore.gmt.GMT_DATAand thenz_map_datareferences in the examples.