Skip to content

Patchgrid Improvement#346

Merged
lispandfound merged 12 commits intomasterfrom
patchgrid_improve
Mar 12, 2025
Merged

Patchgrid Improvement#346
lispandfound merged 12 commits intomasterfrom
patchgrid_improve

Conversation

@lispandfound
Copy link
Contributor

This PR refactors the patchgrid function so that it works without the scipy convolutions. The main advantage of this approach is that it correctly handles the degenerate case where there is only one patch (i.e. the length ~ resolution in either x or y direction).

Enhancements to test cases:

  • qcore/test/test_grid/test_grid.py: Updated the test_grid_corners and test_coordinate_meshgrid functions to improve readability and ensure proper testing of grid creation and distance calculations. [1] [2]
  • qcore/test/test_grid/test_grid.py: Added a new test case test_coordinate_meshgrid_x_boundary to verify the behavior of the coordinate_meshgrid function when there is only one patch in the x and y directions.
  • qcore/test/test_grid/test_grid.py: Updated the test_coordinate_patchgrid function to improve readability and ensure proper testing of patch grid creation and distance calculations.

@lispandfound
Copy link
Contributor Author

Test fails for some reason related to qcore and mantle.

@lispandfound
Copy link
Contributor Author

lispandfound commented Mar 9, 2025

Apparently the ghostscript package has been removed and replaced in Debian Bookworm, which is why the tests are now failing. The bookworm package website is returning a 503 at the moment so I cannot see what happened to the package. Will update it once I know what to change it to. It was actually a configuration error with Jenkins + docker with root. Changed to dockerless Jenkins, tests works now.

@lispandfound lispandfound merged commit 0b298ea into master Mar 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants