Merged
Conversation
Contributor
Author
|
Test fails for some reason related to qcore and mantle. |
AndrewRidden-Harper
previously approved these changes
Mar 7, 2025
Contributor
Author
|
|
joelridden
approved these changes
Mar 12, 2025
AndrewRidden-Harper
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the patchgrid function so that it works without the scipy convolutions. The main advantage of this approach is that it correctly handles the degenerate case where there is only one patch (i.e. the length ~ resolution in either x or y direction).
Enhancements to test cases:
qcore/test/test_grid/test_grid.py: Updated thetest_grid_cornersandtest_coordinate_meshgridfunctions to improve readability and ensure proper testing of grid creation and distance calculations. [1] [2]qcore/test/test_grid/test_grid.py: Added a new test casetest_coordinate_meshgrid_x_boundaryto verify the behavior of thecoordinate_meshgridfunction when there is only one patch in the x and y directions.qcore/test/test_grid/test_grid.py: Updated thetest_coordinate_patchgridfunction to improve readability and ensure proper testing of patch grid creation and distance calculations.