Add comprehensive test coverage for non-omitted modules#359
Merged
lispandfound merged 3 commits intotype_checkingfrom Nov 13, 2025
Merged
Add comprehensive test coverage for non-omitted modules#359lispandfound merged 3 commits intotype_checkingfrom
lispandfound merged 3 commits intotype_checkingfrom
Conversation
Co-authored-by: lispandfound <12835929+lispandfound@users.noreply.github.com>
Contributor
|
@copilot try adding extra test cases in the geo module. |
Copilot
AI
changed the title
[WIP] Align standards with the rest of the codebase
Add test coverage for explicit raise statements in non-omitted modules
Nov 13, 2025
Co-authored-by: lispandfound <12835929+lispandfound@users.noreply.github.com>
Author
Added comprehensive test coverage for the geo module, improving coverage from 49% to 100%. The changes include 13 new test cases covering:
All 46 tests in test_geo.py now pass. See commit a68c3ff. |
Copilot
AI
changed the title
Add test coverage for explicit raise statements in non-omitted modules
Add comprehensive test coverage for non-omitted modules
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds comprehensive test coverage for all modules not excluded from coverage checks (
grid.py,siteamp_models.py,timeseries.py,xyts.py,geo.py).Changes
ValueErrorwhencoordinate_patchgrid()called without resolution or nx/nycb_amp_multi():ZeroDivisionErrorinampdeamp()with zero amplification factorValueErrorfor invalid LFSeis file format in parser constructorValueErrorwhen no seis files found in directoryValueErrorfor invalid XYTS file formatAttributeErrorwhen callingtslice_get()orpgv()on meta-only instancesget_distances,closest_location)gen_mat,xy2ll,ll2xy,gp2xy)rotation_matrix,angle_diffedge cases)path_from_corners)ll_cross_along_track_dist)Coverage Impact
All 25 new test cases pass with no security issues detected.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.