Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BDC cell sweep #25

Open
rland93 opened this issue Nov 12, 2021 · 1 comment · Fixed by #62
Open

BDC cell sweep #25

rland93 opened this issue Nov 12, 2021 · 1 comment · Fixed by #62
Assignees
Labels
enhancement New feature or request hard A particularly difficult feature or bug
Milestone

Comments

@rland93
Copy link
Member

rland93 commented Nov 12, 2021

Right now, each node of the Reeb Graph generated by bdc.py's line sweep (R called on line 175 of bdc.py) has an attribute called cellpts that stores the affine polygon produced by the boustrophedon decomposition of the shape.

We need to "lawnmower sweep" each of these cells as we traverse the reeb graph, skipping over cells that have already been swept.

Down the line, a sweep algorithm would optimize sweeping from starting exit/entry points and sweeping in order. Or, if the cell is strictly convex in multiple directions, we can choose an optimal direction for the line sweep. Or, we can solve an optimization problem to determine the mixture of exit/entry points, sweep direction, etc.

@rland93 rland93 transferred this issue from another repository Apr 24, 2022
@rland93
Copy link
Member Author

rland93 commented May 24, 2022

Starting work on this. It's been about a year since I touched this code

To do

  • refactor bdc to have OO interface similar to planner
    • polygon
    • bdc
  • test coverage
  • fix polygon skeleton to either use shapely or a similarly high-quality library
  • lawnmower cell sweep
  • make API compatible with planner

@rland93 rland93 added enhancement New feature or request hard A particularly difficult feature or bug labels May 24, 2022
@rland93 rland93 added this to the 0.2.0 milestone May 24, 2022
rland93 added a commit that referenced this issue May 24, 2022
rland93 added a commit that referenced this issue May 24, 2022
@rland93 rland93 linked a pull request May 24, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hard A particularly difficult feature or bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants